Closed shawnzhu closed 1 year ago
🚩 No commit messages matched the required convention
<type>: my commit message
Valid types: feat
, fix
, docs
, style
, refactor
, perf
, test
, chore
, build
, revert
You'll need to either:
See the conventional-commits spec for more details.
Created by lifeomic-probot (Enforce Semantic Commits)
Goal
bring in the row selection capability by using react-table's API.
Progress
it works by adding a new module named
ReactTable
.it will be lots of work to include react-table as a new Chroma component besides
TableModule
, will be lots of work to maintain and deprecateTableModule
afterwards.Conclusion
Based on the similarity of
react-table
andTableModule
API , it would be easier to just refactorTableModule
by addingreact-table
as implementation and make it backward compatible.config
ofTableModule
, no changes to existing apps that use it.columns: ColumnRef[]
to configure TableModule , it will use react-table 's implementation.