lifeomic / chroma-react

Open source design system from LifeOmic, built with React
https://lifeomic.github.io/chroma-react/
MIT License
48 stars 9 forks source link

[PoC] Add a new component ReactTable #330

Closed shawnzhu closed 1 year ago

shawnzhu commented 1 year ago

Goal

bring in the row selection capability by using react-table's API.

Progress

it works by adding a new module named ReactTable.

it will be lots of work to include react-table as a new Chroma component besides TableModule, will be lots of work to maintain and deprecate TableModule afterwards.

Conclusion

Based on the similarity of react-table and TableModule API , it would be easier to just refactor TableModule by adding react-table as implementation and make it backward compatible.

lifeomic-probot[bot] commented 1 year ago

🚩 No commit messages matched the required convention <type>: my commit message

Valid types: feat, fix, docs, style, refactor, perf, test, chore, build, revert

You'll need to either:

See the conventional-commits spec for more details.

Created by lifeomic-probot (Enforce Semantic Commits)