feat: Add title icon to list

lifeomic / chroma-react

Open source design system from LifeOmic, built with React

https://lifeomic.github.io/chroma-react/

MIT License

48 stars 9 forks source link

feat: Add title icon to list #368

Closed dexterca closed 1 year ago

dexterca commented 1 year ago

I noticed title prop was getting rendered as a <div> as a direct descendent of a <ul>, which was failing a11y checks due to invalid markup. I'm adjusting the markup in this PR so that title precedes the <ul>, identical to the way title is handled in <DescriptionList.

Changes

Add titleIcon prop to <List
Make title and title icon styles consistent between list and description list

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 4.6.0 :tada:

The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: