lifeomic / chroma-react

Open source design system from LifeOmic, built with React

https://lifeomic.github.io/chroma-react/

MIT License

48 stars 9 forks source link

Update to Storybook 7 #370

Closed MMFane closed 1 year ago

MMFane commented 1 year ago

What’s New

Several Breaking Changes

see the migration guide for more details

Now using Webpack5
IE11 support discontinued
Node 16 minimum
Babel mode v7
Start and build CLI binaries removed
Some community add-ons might not work yet

Formatting Updates

MDX1 upgraded to MDX2
storiesOf support is fully discontinued - We had already upgraded to the Component Stories Format (CSF) thanks to @nicolls1’s Storybook 6 upgrade
CSF3 has been released. Look forward to a second PR updating our components to use its more streamlined formatting.
- Improved Type Safety

lifeomic-probot[bot] commented 1 year ago

⚠️ Detected a breaking change in commit 988fb93

Merging this PR will result in a major version bump.

Created by lifeomic-probot (Enforce Semantic Commits)

shawnzhu commented 1 year ago

closes #357

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 5.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

MMFane commented 1 year ago

Question: While this is a certainly a breaking change in storybook, does it really represent a breaking change in chroma? To me, seems like this PR will not modify consumer-facing behavior in any way, so maybe it can just be left as docs: rather than docs!:.

Hey @swain ! Yeah, I wasn't 100% sure - what pushed me over to calling it a breaking change was that it requires Webpack5, but maybe that was overcautious? I'd love to understand better for future PRs

swain commented 1 year ago

@MMFane Sounds good. I'll move discussion to Slack :)