search

lifeomic / chroma-react

Open source design system from LifeOmic, built with React
https://lifeomic.github.io/chroma-react/
MIT License
48 stars 9 forks source link

feat: upgrade framer-motion #412

Closed jkdowdle closed 9 months ago

jkdowdle commented 9 months ago

Changes

Motivation

The reason for this change is because we've recently ran into an odd issue where using checkboxes in a mobile scroll view can cause some bad ux.

As a user scrolls + checks a checkbox the checkbox appears to animate to a checked or even partial checked state - but the value never actually was toggled. Then when a checkbox is actually toggled in the group, the "partial" checked revert

I believe it is an issue with starting but never ending the animation - this issue seems to addressed or handled better in later versions of framer-motion

See the before video for a better idea.

Behavior

Before

https://github.com/lifeomic/chroma-react/assets/19804196/0695e065-223e-48f7-b4b6-29426cd61a00

After

https://github.com/lifeomic/chroma-react/assets/19804196/123a0b3e-5498-49a4-815c-ebb68b29fb77

github-actions[bot] commented 9 months ago

:tada: This PR is included in version 5.7.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: