move aws-xray-sdk-core to peer dependencies

lifeomic / graphql-resolvers-xray-tracing

A GraphQL middleware to enable X-Ray tracing subsegments for GraphQL resolvers

MIT License

68 stars 16 forks source link

move aws-xray-sdk-core to peer dependencies #23

Closed Druotic closed 5 years ago

Druotic commented 5 years ago

This caused an issue where I had to explicitly use yarn upgrade @lifeomic/graphql-resolvers-xray-tracing because it was pulling in it's own (older) version of the sdk. Having this as a peer dependency will help ensure no unexpected versions are used. I also added it as a dev dependency so that local linking will work when developing against this project.

mdlavin commented 5 years ago

@Druotic I'll release a major version bump in a sec

mdlavin commented 5 years ago

Releasing as 3.0.0 now

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 111

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 95:	0.0%
Covered Lines:	22
Relevant Lines:	22

lifeomic / graphql-resolvers-xray-tracing

move aws-xray-sdk-core to peer dependencies #23

Pull Request Test Coverage Report for Build 111

💛 - Coveralls