Serialize error before sending to xray

lifeomic / graphql-resolvers-xray-tracing

A GraphQL middleware to enable X-Ray tracing subsegments for GraphQL resolvers

MIT License

68 stars 16 forks source link

Serialize error before sending to xray #59

Open andyrichardson opened 3 years ago

andyrichardson commented 3 years ago

About

Fix #58

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 351

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 350:	0.0%
Covered Lines:	22
Relevant Lines:	22

💛 - Coveralls

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 351

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 350:	0.0%
Covered Lines:	22
Relevant Lines:	22

💛 - Coveralls

mdlavin commented 3 years ago

Would it be possible to detect errors with circular references and only serialize those? I'm not sure about the impact of loosing the original error in the common case of non-circular errors.