search

lifeomic / graphql-resolvers-xray-tracing

A GraphQL middleware to enable X-Ray tracing subsegments for GraphQL resolvers
MIT License
68 stars 16 forks source link

Error on tsc #69

Closed danilobuerger closed 3 years ago

danilobuerger commented 3 years ago

When running tsc I am getting the following error:

❯ yarn run tsc --noEmit
yarn run v1.22.10
$ node_modules/.bin/tsc --noEmit
node_modules/@lifeomic/graphql-resolvers-xray-tracing/src/traceResolvers.ts:26:23 - error TS1196: Catch clause variable cannot have a type annotation.

26       } catch (error: any) {
                         ~~~

Found 1 error.
mdlavin commented 3 years ago

Interesting, it just be some new strictness in the TypeScript compiler. If you want to put a PR up to fix it, I'd be happy to merge it and release a new version

mikemeerschaert commented 3 years ago

I just submitted a PR with a fix for this, would you mind merging when you get a chance?

Thanks!

mdlavin commented 3 years ago

I merged your PR and it should get released soon

mikemeerschaert commented 3 years ago

Thanks for getting that added so fast, nobody else on my team even noticed an issue when they built my latest commit!