search

lifeomic / lambda-tools

Common utilities for Lambda testing and development
MIT License
23 stars 7 forks source link

chore: make typescript happy #344

Closed DavidTanner closed 1 year ago

DavidTanner commented 1 year ago

gag

Just because there are so many projects still using this...

swain commented 1 year ago

@DavidTanner CI is failing on this PR.

swain commented 1 year ago

@DavidTanner Also, I think I'm missing some context that other reviewers might have. What problem is being fixed by this PR?

DavidTanner commented 1 year ago

Was just trying to make the build happy. There are many dependabot builds failing. I'm not inclined to put much effort into keeping this project alive, I was just hoping this would help the automation.

swain commented 1 year ago

@DavidTanner Ah, I see.

My personal recommendation: since this project is not actively maintained, I'd just approve and merge the dependabot PRs (even though they are failing CI). That will at least clear them from your queue, and ~also resolve the security issues~.

edit: won't resolve the security issue, but I'd propose that's low-priority anyway.