liferay-labs-br / fiber

The framework specialized in animated components.
MIT License
5 stars 4 forks source link

Create API public of the render #44

Closed matuzalemsteles closed 7 years ago

matuzalemsteles commented 7 years ago

Disclaimer

API can be more intuitive when separating by packets.

I'm just sending back the modifications made in pr #36, the API continues in the same way.

My thinking of abstracting the logic of a render in the isomorphic folder is that we can leave there, all the logic that involves the assembly of a component and not put anything that touches the dom or that is very specific for the type of the render . Giving the opportunity to create several different renderers.

Change

Future

We can make the API more accessible by separating by packages, using the lerna with yarn workspace.

isomorphic > fiber renderers/dom > fiber-dom

fiber-dom can consume renderFactory from the fiber package.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.4%) to 94.488% when pulling 03d1d16d9abfd90a32354d83797e89c8375be31a on matuzalemsteles:abstract-render into e9896028290147aed4fa0cf29a67ab8224898b0e on liferay-labs-br:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.3%) to 94.444% when pulling 12d6b5af4317dfa971c3861cc8d658600c63b968 on matuzalemsteles:abstract-render into e9896028290147aed4fa0cf29a67ab8224898b0e on liferay-labs-br:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.3%) to 94.444% when pulling cfdfe7ea2d33f547b63acd544d386d2fee7f1b75 on matuzalemsteles:abstract-render into e9896028290147aed4fa0cf29a67ab8224898b0e on liferay-labs-br:master.