API can be more intuitive when separating by packets.
I'm just sending back the modifications made in pr #36, the API continues in the same way.
My thinking of abstracting the logic of a render in the isomorphic folder is that we can leave there, all the logic that involves the assembly of a component and not put anything that touches the dom or that is very specific for the type of the render . Giving the opportunity to create several different renderers.
Change
Move file renderers/render to renderers/dom/render and expose from the fiber.js file. 8641b91
Future
We can make the API more accessible by separating by packages, using the lerna with yarn workspace.
isomorphic > fiberrenderers/dom > fiber-dom
fiber-dom can consume renderFactory from the fiber package.
Coverage increased (+0.4%) to 94.488% when pulling 03d1d16d9abfd90a32354d83797e89c8375be31a on matuzalemsteles:abstract-render into e9896028290147aed4fa0cf29a67ab8224898b0e on liferay-labs-br:master.
Coverage increased (+0.3%) to 94.444% when pulling 12d6b5af4317dfa971c3861cc8d658600c63b968 on matuzalemsteles:abstract-render into e9896028290147aed4fa0cf29a67ab8224898b0e on liferay-labs-br:master.
Coverage increased (+0.3%) to 94.444% when pulling cfdfe7ea2d33f547b63acd544d386d2fee7f1b75 on matuzalemsteles:abstract-render into e9896028290147aed4fa0cf29a67ab8224898b0e on liferay-labs-br:master.
Disclaimer
I'm just sending back the modifications made in pr #36, the API continues in the same way.
My thinking of abstracting the logic of a
render
in theisomorphic
folder is that we can leave there, all the logic that involves the assembly of a component and not put anything that touches the dom or that is very specific for the type of the render . Giving the opportunity to create several different renderers.Change
renderers/render
torenderers/dom/render
and expose from thefiber.js
file. 8641b91Future
We can make the API more accessible by separating by packages, using the lerna with yarn workspace.
isomorphic
>fiber
renderers/dom
>fiber-dom
fiber-dom
can consumerenderFactory
from thefiber
package.