Closed matuzalemsteles closed 6 years ago
Just putting here, what was said in #5 to continue the speech.
cc @clovisdasilvaneto
My proposal is a consistency of names among the files, we currently have:
.
+-- isomorphic
| +-- component.js
| +-- createComponent.js
| +-- element.js
+-- renderers
| +-- render.js
My idea is that we use FooBar
for filenames and starting with Fiber
:
.
+-- isomorphic
| +-- FiberComponent.js or FiberBaseClass.js
| +-- FiberCreateComponent.js
| +-- FiberElement.js
+-- renderers
| +-- FiberRender.js
What do you think?
That sounds like good, I think is perfect
Okay, I'm going to send a pr with this change.
Hey, Your issue has been resolved 🎉, Thanks!
Disclaimer
We need to design the architecture of the files thinking of server-side rendering and center the Fiber core as isomorphic.
Suggestion
We can think of a multi-package repository using lerna, but putting all the files in
src
and packages inpackages
with an index giving arequire
to their corresponding files to centralize the share of some libs. Create a folder calledisomorphic
to center the core of the fiber.API of component
We can create a
src/isomorphic/FiberBaseClass.js
file as aComponent
API contract to be reused with components outside the browser or as a native app in the future.