liferay-labs / arquillian-liferay

Arquillian Liferay Extension
Apache License 2.0
8 stars 13 forks source link

Upgrade project to Liferay 7.1 #25

Closed kriegaex closed 5 years ago

kriegaex commented 6 years ago

Attention! This PR also encompasses the yet unmerged PR #24 - sorry for that, but I do not want to wait until that one was also reviewed. The new commits start from today (2018-10-18), i.e. at the time of writing there are three (3) commits specific to this branch.

What was done is mentioned in the commit messages, please read them. Basically it was as follows:

P.S.: This PR is an indirect result of my troubles related to #19. See also my comments there in order to understand why it is now more complicated to activate JMX hot-deployment in 7.1.

Update: Commit fb11446 should fix the problem with module auto-activation mentioned in the troubleshooting section of the read-me file. I still have not removed that section because maybe the problem can still occur under certain circumstances. I can only test on my machine.

Update 2: My assumption for the Travis CI build failure is that the initial Liferay start after download + unzip just takes too long, even longer than the 350 s configured in Maven. On my machine it takes twice as long during the first time due to validation: org.apache.catalina.startup.Catalina.start Server startup in 692020 ms

csierra commented 6 years ago

hi @kriegaex we have been very busy these days... sorry for the long delay. we will have a look as soon as we can.

Thx for you contribution!

cgoncas commented 5 years ago

Just started reviewing :)

:octocat: Sent from GH.