Attention! This PR also encompasses the yet unmerged PR #24 - sorry for that, but I do not want to wait until that one was also reviewed. The new commits start from today (2018-10-18), i.e. at the time of writing there are three (3) commits specific to this branch.
What was done is mentioned in the commit messages, please read them. Basically it was as follows:
Upgrade download to Liferay 7.1 + Tomcat 9.0.6
Upgrade tests to run on LR 7.1
In 7.0 only one module was missing in order to enable JMX hot-deployment. In 7.1 five (5) modules are needed. Thus I decided to copy them to osgi/modules directly instead of trying to install them from Java, which would be impossible in the first place because _installBundle(_getMavenDependencyPath(_HOT_DEPLOY_JMX_LISTENER_MVN)) would not work anyway before installing the server-side dependencies to make a call to _installBundle possible in the first place.
P.S.: This PR is an indirect result of my troubles related to #19. See also my comments there in order to understand why it is now more complicated to activate JMX hot-deployment in 7.1.
Update: Commit fb11446 should fix the problem with module auto-activation mentioned in the troubleshooting section of the read-me file. I still have not removed that section because maybe the problem can still occur under certain circumstances. I can only test on my machine.
Update 2: My assumption for the Travis CI build failure is that the initial Liferay start after download + unzip just takes too long, even longer than the 350 s configured in Maven. On my machine it takes twice as long during the first time due to validation: org.apache.catalina.startup.Catalina.start Server startup in 692020 ms
Attention! This PR also encompasses the yet unmerged PR #24 - sorry for that, but I do not want to wait until that one was also reviewed. The new commits start from today (2018-10-18), i.e. at the time of writing there are three (3) commits specific to this branch.
What was done is mentioned in the commit messages, please read them. Basically it was as follows:
_installBundle(_getMavenDependencyPath(_HOT_DEPLOY_JMX_LISTENER_MVN))
would not work anyway before installing the server-side dependencies to make a call to_installBundle
possible in the first place.P.S.: This PR is an indirect result of my troubles related to #19. See also my comments there in order to understand why it is now more complicated to activate JMX hot-deployment in 7.1.
Update: Commit fb11446 should fix the problem with module auto-activation mentioned in the troubleshooting section of the read-me file. I still have not removed that section because maybe the problem can still occur under certain circumstances. I can only test on my machine.
Update 2: My assumption for the Travis CI build failure is that the initial Liferay start after download + unzip just takes too long, even longer than the 350 s configured in Maven. On my machine it takes twice as long during the first time due to validation:
org.apache.catalina.startup.Catalina.start Server startup in 692020 ms