search

liferay / clay

A web implementation of the Lexicon Experience Language
http://clayui.com
Other
208 stars 483 forks source link

Explore changing the icons viewbox from 512px to 16px #4763

Open emiliano-cicero opened 2 years ago

emiliano-cicero commented 2 years ago

What is your proposal?

We are using a viewBox of 512px (0 0 512 512) for our SVG icons but our most common use case is Portal and other digital products from Liferay where we use them at a size of 16px. My proposal is to update the viewBox to match the common usage of the icons which is 16px (0 0 16 16). As they're SVGs we can increase the size without problems so there shouldn't be a problem to remove the 512px.

Why would adopting this proposal be beneficial?

The main benefit is that we will be able to create 16px icons and implement them directly without having to resize them twice (one to fit the 512 viewBox and a second time to fit the 16px in the products).

What are the alternatives to this proposal?

The alternative would be to keep it as it is.

I'm requesting this issue as an Exploration just to see what would be the problems of doing this.

pat270 commented 2 years ago

I don't see any problem with updating the icon's viewBox. The icons will still render the same. We will need to export all the icons again though. We can't change viewBox="0 0 16 16" on old icons and expect it to work.