search

liferay / clay

A web implementation of the Lexicon Experience Language
http://clayui.com
Other
208 stars 467 forks source link

docs(@icons): Change icons resolution to 16px #5741

Closed ilzamcmed closed 5 months ago

ilzamcmed commented 6 months ago

Jira issue: https://liferay.atlassian.net/browse/LPS-201961

ilzamcmed commented 6 months ago

Hey @pat270 , this PR is ready for review Thanks!

pat270 commented 6 months ago

@ilzamcmed it looks pretty good! The only change we need is to remove fill="#000" from many of the icons. It doesn't inherit color changes.

Screen Shot 2023-12-14 at 2 44 42 PM

All the icons should be blue not black.

ilzamcmed commented 6 months ago

Thanks @pat270 I believe everything is ok now. The only question I have is related to the icons called Union (didn't find any related one) and Vector (this one is similar to the geolocation icon but a bit small).

pat270 commented 6 months ago

@ilzamcmed we can rename the two icons

union 5 => unpin.svg
vector 1 => geolocation.svg
ilzamcmed commented 6 months ago

@emiliano-cicero There were some icons not included in the zip. These icons are still viewBox="0 0 512 512". Are we deleting them? If we do, there will be complications and we will probably have to provide backward compatibility.

add-role.svg
align-right.svg
anonymize.svg
arrow-right-full.svg
arrow-up-full.svg
automatic-translate.svg
bell-full.svg
bolt.svg
change-list-disabled.svg
comments.svg
custom-field.svg
desktop.svg
devices.svg
diagonal-line.svg
embed.svg
environment-connected.svg
environment-disconnected.svg
environment.svg
geolocation.svg (vector 1.svg)
import-export.svg
info-panel-closed.svg
lock-dots.svg
megaphone-full.svg
minus-circle.svg
order-arrow.svg
order-form-pencil.svg
order-list-down.svg
order-list-up.svg
pages-tree.svg
pin-full.svg
product-menu.svg
rectangle.svg
relationship.svg
remove-role.svg
reset.svg
share-alt.svg
sign-in.svg
social-twitter.svg
sticky.svg
textbox.svg
third-party.svg
twitter-x.svg
unpin.svg (union 5.svg)
upload-multiple.svg
urgent.svg
warning-full.svg

Should we consider the flags also? They are all viewBox="0 0 512 512"

pat270 commented 6 months ago

Yes flags should be converted too.

emiliano-cicero commented 6 months ago

hey guys, sorry the export changed some of the names of the icons and I will need to review them one by one to make it work

ilzamcmed commented 6 months ago

Hey @emiliano-cicero , do you have any updates on the icons? Thanks!

ilzamcmed commented 5 months ago

To be sent in another moment after design icons review