search

liferay / clay

A web implementation of the Lexicon Experience Language
http://clayui.com
Other
207 stars 470 forks source link

LPD-17368 Accessibility issue in Pagination Picker #5764

Closed ilzamcmed closed 7 months ago

ilzamcmed commented 7 months ago

Jira issue: https://liferay.atlassian.net/browse/LPD-17368

ethib137 commented 7 months ago

Since we are adding a new language key in this PR, when we release this in Portal we will need to simultaneously add a new language key to language.properties and add the additional key to all usages of this component. @ilzamcmed can you create a ticket for this? @matuzalemsteles do we already have a process for making sure we apply these additional changes to portal as part of the Clay release?

matuzalemsteles commented 7 months ago

do we already have a process for making sure we apply these additional changes to portal as part of the Clay release?

In fact we have no process for this, when we add a new key, we make this key optional when it is inside the object to avoid a breaking change, for example when the component has already declared labels but a new key was added this would cause a build error. So this is treated as breaking change.

We normally do this but we don't update all DXP use cases due to workforce so as not to delay the release. But we can include this or we can start prioritizing the work on integrating Liferay.Language with the portal so that we only need to change in one place.

ethib137 commented 7 months ago

Thanks @matuzalemsteles , that makes sense.

But we can include this or we can start prioritizing the work on integrating Liferay.Language with the portal so that we only need to change in one place.

I think it makes more sense to prioritize integrating Liferay.Language, like we've discussed before. Something like a ClayMessageProvider. Do you remember where we discussed this previously. I think it was on a ticket or something. I'll create a new story for this and start working on the requirements.

matuzalemsteles commented 7 months ago

I think it makes more sense to prioritize integrating Liferay.Language, like we've discussed before. Something like a ClayMessageProvider. Do you remember where we discussed this previously. I think it was on a ticket or something. I'll create a new story for this and start working on the requirements.

Yes, something like that. We have a ticket that discussed this but I think we need to create another one with this type of story. https://liferay.atlassian.net/browse/LPS-190534