search

liferay / clay

A web implementation of the Lexicon Experience Language
http://clayui.com
Other
208 stars 467 forks source link

docs(clayui.com): Remove secondary, tertiary, and danger link examples. #5785

Closed SelenaAungst closed 3 months ago

SelenaAungst commented 3 months ago

https://liferay.atlassian.net/browse/LPD-17393 I was not 100% sure that these are all the changes being requested so please let me know if anything is missing/incorrect from this!

SelenaAungst commented 3 months ago

Hi @matuzalemsteles, Thanks for pointing this out! I removed the Font Size example. Additionally, I was not sure if this line should be changed as well:

image

"The available values are 'primary', 'secondary', 'danger', and 'tertiary'." Should this just be changed to "The available value is 'primary'." or should this part be removed now that the other options are gone?

matuzalemsteles commented 3 months ago

@SelenaAungst I think we can remove and leave this documented only in the API part at this point.

SelenaAungst commented 3 months ago

Thanks @matuzalemsteles! I removed that part. Does anything else need to be added/removed for this?

matuzalemsteles commented 3 months ago

@SelenaAungst I think that's just it. Thanks!

@drakonux or @emiliano-cicero can you guys validate this before merging?

SelenaAungst commented 3 months ago

From a Slack discussion of this ticket:

For links, I think that at the content level, and as Matu says, we should delete references to the rest of displayTypes, we can remove the whole reference, even the sentence “You can style a link…“. And actually Semi Bold, Outline, Borderless and Monospaced sections could be also removed, if it’s clear on the API tab, it’s enough

I will add a new commit with these changes.