search

liferay / clay

A web implementation of the Lexicon Experience Language
http://clayui.com
Other
207 stars 470 forks source link

fix(@clayui/css): update footer spacing in the modal #5802

Closed matuzalemsteles closed 5 months ago

matuzalemsteles commented 5 months ago

Ticket LPD-18361

pat270 commented 5 months ago

@matuzalemsteles we should update the padding in cadmin too. I was afraid the taller footer height might mess up some older modals in DXP, but it looks like we have DXP specific CSS for those.

matuzalemsteles commented 5 months ago

We need to update in cadmin too.

Updated!

I was afraid the taller footer height might mess up some older modals in DXP, but it looks like we have DXP specific CSS for those.

Hmm, I don't know if I understand very well, do you think this could affect old modals? visually what would be the side effect of this? I think changing the old modals would also be good since we want to standardize but I may be missing something here.

pat270 commented 5 months ago

The example I'm thinking about is the permissions modal. We have CSS in DXP for that.

permissions