search

liferay / clay

A web implementation of the Lexicon Experience Language
http://clayui.com
Other
207 stars 470 forks source link

refactor(@clayui/treeview): LPD-19473 Improve TreeView Contrast on Active and Hover states #5820

Closed ilzamcmed closed 4 months ago

ilzamcmed commented 4 months ago

Jira issue: https://liferay.atlassian.net/browse/LPD-19473

Evidence: https://github.com/liferay/clay/assets/47724428/2626eb39-a74a-49a7-b1d5-2a7a07b99dac

ilzamcmed commented 4 months ago

Hey @matuzalemsteles @pat270 @ethib137 This PR is ready for review! Thanks!

pat270 commented 4 months ago

@ilzamcmed there are issues with open tree view items getting the active selected state. active-class We need to remove the changes from active-class. We also need to add active: (focus: ()) styles and update treeview-dark too.

ilzamcmed commented 4 months ago

Thanks @pat270! I'll work on those behaviors.

pat270 commented 4 months ago

@ilzamcmed I took a look and updated the borders to use box-shadow instead of border. It keeps the styles more consistent when the state changes.

box-shadow

ilzamcmed commented 4 months ago

Thanks @pat270!!