search

liferay / clay

A web implementation of the Lexicon Experience Language
http://clayui.com
Other
208 stars 483 forks source link

fix(@clayui/form): LPD-36696 DualListBox adds children and don't disable left right buttons if no items are selected #5874

Closed pat270 closed 3 weeks ago

pat270 commented 2 months ago

https://liferay.atlassian.net/browse/LPD-36696

I added children to the component so we can pass in things like an error message. I also removed disabling the move buttons if length is 0.

duallistbox-new

matuzalemsteles commented 1 month ago

Just an update on this, I spoke to Patrick and will get to work on it, should have something this week.

matuzalemsteles commented 1 month ago

I'm moving the entire validation system to the component as well as the error message with translation support, also adding new APIs to configure the maximum number of items for both sides.

matuzalemsteles commented 1 month ago

Hey @pat270 What do you think of these changes? Is this a rule that can be applied to all cases?

pat270 commented 3 weeks ago

@matuzalemsteles It's not working correctly for me for some reason. Here is a gif of what I'm seeing. duallistbox

pat270 commented 3 weeks ago

@matuzalemsteles I got it to work. Some of the left/right error stuff just needed to be swapped.