search

liferay / clay

A web implementation of the Lexicon Experience Language
http://clayui.com
Other
208 stars 483 forks source link

LPD-35107 - Update sorting icons for Clay Table #5875

Closed ethib137 closed 1 month ago

ethib137 commented 1 month ago

https://liferay.atlassian.net/browse/LPD-35107

ethib137 commented 1 month ago

@marcoscv-work or @drakonux would one of you mind reviewing the table sorting icons here to make sure it's correct: https://deploy-preview-5875--next-storybook-clayui.netlify.app/?path=/story/design-system-components-table--sorting

drakonux commented 1 month ago

Using your link @ethib137 with my PC, Edge 129.0.2792.79 (64 bits), at 100% zoom, one of the new ordering icons (order-list-down) seems cut. Zooming in, it looks perfect 🤷‍♂️

Could you check it?

screenshot-icon-cut

ethib137 commented 1 month ago

@drakonux I don't see that issue on my computer either. If you want to create a bug ticket for it we can try to look into it, but I don't think it should block us merging this.

ethib137 commented 1 month ago

@pat270 or @matuzalemsteles can you merge this if it looks okay?

ethib137 commented 1 month ago

Thanks @matuzalemsteles when will we be cutting the next Clay release and putting this in Portal?

matuzalemsteles commented 1 month ago

@ethib137 We will cut it next Monday. If you need it sooner we can cut one today or tomorrow.

ethib137 commented 1 month ago

Hey @matuzalemsteles if we could cut it sooner that would be very helpful. Thanks.