search

liferay / clay

A web implementation of the Lexicon Experience Language
http://clayui.com
Other
208 stars 483 forks source link

feat(@clayui/css): LPD-39299 Adds d4-l1 for colors #5877

Closed pat270 closed 1 month ago

pat270 commented 1 month ago

https://liferay.atlassian.net/browse/LPD-39299

This needs to make it into DXP before we can merge https://github.com/liferay-platform-experience/liferay-portal/pull/753

ethib137 commented 1 month ago

LGTM... just one question... If we are using the same value for atlas and default variables do we have to duplicate it? Instead can we just leave out the variables from atlas? I'm guessing you are adding the variables to atlas because this is an existing pattern, but I just wanted to check. Thanks.

ethib137 commented 1 month ago

@matuzalemsteles Let's make sure this is in the early release as well.

pat270 commented 1 month ago

@ethib137 yeah we can leave it out from atlas. I duplicate it because it's much easier to copy and paste global variables for developers wanting to extend Atlas theme.

ethib137 commented 1 month ago

No problem, if thats our existing pattern then thats fine. thanks