Adds support for customizing the main folder name for unZip export

liferay / electric

⚡ Create beautiful documentation for your projects

https://electricjs.com

Other

118 stars 26 forks source link

Adds support for customizing the main folder name for unZip export | Fixes #123 #124

Closed matuzalemsteles closed 6 years ago

matuzalemsteles commented 6 years ago

I did not think of a better name for this API, please if you have something better in mind, feel free to.

New

Adds to apiConfig.project mainFolderName to customize the main project folder for extraction.

jbalsas commented 6 years ago

Hey @matuzalemsteles, what about srcFolder or srcPath or pathSrc?

matuzalemsteles commented 6 years ago

Hey @jbalsas , srcFolder looks good to me, what do you think?

jbalsas commented 6 years ago

👍 @zenorocha, any particular preference?

zenorocha commented 6 years ago

I'd vote for srcPath which matches the pattern we're using here:

https://electricjs.com/docs/configuration/#options

matuzalemsteles commented 6 years ago

Hey @zenorocha looks good to me. @jbalsas what do you think?

jbalsas commented 6 years ago

Sure, sounds good to me. Can you go ahead and change this, @matuzalemsteles?

jbalsas commented 6 years ago

Merged, thanks!

@zenorocha, I haven't released electric so far, so I'm not sure if we're following any particular workflow. Can you take care of this one, or let me know how to proceed from now on?

Thanks!