search

liferay / electric

⚡ Create beautiful documentation for your projects
https://electricjs.com
Other
118 stars 26 forks source link

Make footer component usable in all generated files #137

Closed diegonvs closed 6 years ago

diegonvs commented 6 years ago

/cc @zenorocha

zenorocha commented 6 years ago

Just started reviewing :)

:octocat: Sent from GH.

zenorocha commented 6 years ago

Hey @diegonvs,

I saw some problems:

Home

screen shot 2018-03-15 at 4 00 18 pm

Documentation

screen shot 2018-03-15 at 4 00 14 pm

Missing on Documentation pages

screen shot 2018-03-15 at 4 05 16 pm
jbalsas commented 6 years ago

Hey @zenorocha, do you think this is fixed?

@diegonvs, @matuzalemsteles, how should I go on to test and verify this before merging? I haven't been that involved in electric development so far.

jbalsas commented 6 years ago

Merging to develop so we can test there with everything else on top!