fix: Simplify preview command (LPS-152388)

liferay / generator-liferay-fragments

Yeoman generator for creating and maintaining Liferay Fragment projects

https://www.npmjs.com/package/generator-liferay-fragments

MIT License

30 stars 31 forks source link

fix: Simplify preview command (LPS-152388) #235

Closed p2kmgcl closed 2 years ago

p2kmgcl commented 2 years ago

Basically I have rewritten the whole preview script (it was a bit hard to follow). Now it does less things, and parameters should not be updated on reload.

victorg1991 commented 2 years ago

Está muy bien eh?

victorg1991 commented 2 years ago

Approved 👍

sandrodw3 commented 2 years ago

La veo genial, por mí para alante 😄

p2kmgcl commented 2 years ago

Release to test this feature: 2.0.2-rc1

victorg1991 commented 2 years ago

In general it works fine 👏 Just a couple of thing I noticed:

if you open the url without query string like localhost:xxx/fragment-preview the fragment type is selected but you cannot choose any, you have to switch to page templates and back to fragments.
When changing from fragments to page template and the user doesn't have page template the fragment is kept rendered

p2kmgcl commented 2 years ago

Fixed :smile: