search

liferay / liferay-aui-upgrade-tool

Upgrade themes/plugins from Liferay Portal 6.1 to 6.2
13 stars 94 forks source link

LAUT does not insert replace ".aui-XXX" CSS class names with ".aui XXX" for 6.2.x #42

Open timtelcik opened 10 years ago

timtelcik commented 10 years ago

Hello LAUT Support (aka. Iliyan),

I found a bug in LAUT with Git ID d679dfd41619c0ebb701c63e66fe2ef42466ce02 when using LAUT for update a hook plugin for 6.2.x

LAUT is replacing CSS class names from 6.1.x such as this:

.aui-fieldset { margin-top: 0px; margin-bottom: 14px; margin-left: 0px; margin-right: 0px; }

with CSS class names for 6.2.x such as this

.fieldset { margin-top: 0px; margin-bottom: 14px; margin-left: 0px; margin-right: 0px; }

The correct CSS class name for 6.2.x should be

.aui .fieldset { margin-top: 0px; margin-bottom: 14px; margin-left: 0px; margin-right: 0px; }

Hence, the ‘aui-‘ CSS prefix is now a parent ‘.aui’ class.

My current workaround is to perform a manual search and replace after running LAUT.

Please review and advise when an update will be available.

Thank you

Tim

ipeychev commented 10 years ago

Hey Tim,

Thank you for the report! I will try to fix this on the next release.

timtelcik commented 10 years ago

Hello Iliyan,

the "AlloyUI 2.0 / Bootstrap Migration" topic at "https://www.liferay.com/documentation/liferay-portal/6.2/development/-/ai/alloyui-2-0-bootstrap-migration-liferay-portal-6-2-dev-guide-02-en" outlines the process for removing the "aui-" prefix from CSS entry "aui-XXX", but does not discuss inserting ".aui XXX".

My summary outlined above is based on reviewing the CSS entries in the DOM for LP 6.2 pages using Firebug in Firefox and Firefox's Developer Tools. The DOM is littered with CSS entries with the ".aui" pattern.

Can you please eview this issue with the UI team (eg. Nate) and/or the documentation team to uncover what is expected behaviour versus actual behaviour and also whether the migration summary is up to date ?

Thank you

Tim

ipeychev commented 10 years ago

This one is not easy to solve, because it depends on the context. In some cases adding .aui in front of the class will not work, that's why it cannot be added in the Tool. At most we can add a warning that something may not work.

timtelcik commented 10 years ago

Hello Iliyan,

given the issue surrounding context sensitivity of CSS class names, I think a warning message will be helpful.

I will also contact the documentation team to consider revising the bootstrap migration topic with this context issue in mind.

Thanks

Tim

jhinkey commented 10 years ago

Hi Tim,

Thanks for pointing out this issue. I've updated the documentation, explaining how to style classes that fit this context. I also provided a warning in the LAUT example. See https://www.liferay.com/documentation/liferay-portal/6.2/development/-/ai/alloyui-2-0-bootstrap-migration-liferay-portal-6-2-dev-guide-02-en for these changes.

Thanks again, Jim