search

liferay / liferay-ckeditor

Other
8 stars 49 forks source link

fix: add the ability to center images #117

Closed julien closed 4 years ago

julien commented 4 years ago

This fixes https://issues.liferay.com/browse/LPS-115747.

The image plugin's dialog has been patched and now shows an option to "center" images

Before

before

After

centered-image

Note: you'll have to trust me that the console.log message that appear in the second .gif have been removed (although that's visible in the patch)

jbalsas commented 4 years ago

please, check the description in the issues... I think I added detailed information about the different available plugins.

Let's switch to image2 and avoid patching image of possible

julien commented 4 years ago

@jbalsas I did read it, I think that concerning the different plugins they are described in https://issues.liferay.com/browse/LPS-115746 and not https://issues.liferay.com/browse/LPS-115747

So OK, I'll forget about patching and switch to image2

julien commented 4 years ago

Closing because we don't want to patch - since image2 solves this and will be easier than patching

jbalsas commented 4 years ago

All the tasks in this epic are not about blindly implementing the requests rather than figuring out how to best leverage CKEditor's features.

For example, here it's not only about centering images in the dialog, but also in the center align toolbar button and command.

Please, treat all these tasks as opportunities to investigate what CKEditor has to offer and work towards a coherent and unified UX that's also more maintainable for us in the long run.