feat: create and use codemirror plugin

liferay / liferay-ckeditor

Other

8 stars 49 forks source link

feat: create and use codemirror plugin #121

Closed carloslancha closed 4 years ago

carloslancha commented 4 years ago

Follow up of https://github.com/liferay/liferay-ckeditor/pull/120

Removed preview dialog part
Created infra to load codemirror and html-beautify as dependencies

~Problems: When you try to change to source view you get the error html_beautify is not defined, which is being used in the plugin. That dependency was included in the previous minified distribution of codemirror so I guess we need to include it manually, but I'm not sure about the correct package.~

codemirror

Steps to test:

Build liferay-ckeditor
Copy / reference local liferay-ckeditor in liferay-portal
Deploy frontend-editor-ckeditor-web
Go to any editor in portal that uses ckeditor

julien commented 4 years ago

Hey @carloslancha,

Concerning the error you're getting, it's because I was also using the js-beautify package (which also provides html_beautify function) to format the "html" before passing it to the plugin.

This might not be needed, so I was going to look how alloyeditor's source view handled that before sending the final PR.

carloslancha commented 4 years ago

Updated the dependencies script so we create a single vendor file by type.

@julien could you please push a fix for what you commented here ?

julien commented 4 years ago

sorry @carloslancha I was busy with something else. Concerning the fix, I could if I had access to your liferay-ckeditor repository, (I know that GitHub is annoying for that)

It's just a matter of putting the command "registration", i.e. this line

editor.addCommand('codemirror', CKEDITOR.plugins.codemirror.commands.source);

in the init function

julien commented 4 years ago

@carloslancha I'm going to merge this - I still need to add the dialog so I can fix that in the next PR Thanks