search

liferay / liferay-ckeditor

Other
8 stars 49 forks source link

Add padding to active combo buttons to avoid flickering #147

Closed orsolyaDekany closed 3 years ago

orsolyaDekany commented 3 years ago

Hello, Reproduction steps: 1) Edit portal-ext.properties to update the following portal property: editor.wysiwyg.portal-impl.portlet.ddm.text_html.ftl=ckeditor 2) Start 7.2.x 3) Create a new Basic Web Content 4) Hover over the first of the second row (combo button) Result: combo button is flickering Expected: no flickering

flickering

https://issues.liferay.com/browse/LPP-39781

This issue is not present on master because of the combination of LPS-107615 and the latest liferay-ckeditor version "4.14.1-liferay.13"

The issue was introduced with liferay-ckeditor: "4.14.1-liferay.6" with this PR. Padding is added to combo button 6px 18px, however padding of active/hover/focus elements have not changed and it causes flickering on hover.

To fix this and to be alignment with other rows, I add padding on active combo button elements. Now we will not need any margin on combo_button element, so I removed that too. I will link the PR to this issue. Thank you

NemethNorbert commented 3 years ago

https://github.com/liferay/liferay-ckeditor/pull/148

julien commented 3 years ago

Fixed in #148