fix: Make table properties visible

liferay / liferay-ckeditor

Other

8 stars 49 forks source link

Closed rolandpakai closed 3 years ago

rolandpakai commented 3 years ago

On the table Properties modal window the following fields value are not visible

Border size Cell padding Cell spacing The .cke_dialog_ui_labeled_content style should be width: 5em; instead of the width: 3em;

Fixes #149

Before

before

After

after

julien commented 3 years ago

@rolandpakai thanks for submitting this fix, I'm going to review it right now.

In the meantime, could you edit your commit message to something like this?

fix: Make table properties visible

On the table Properties modal window the following fields value are not visible

The .cke_dialog_ui_labeled_content style should be width: 5em; instead of the width: 3em;

Fixes #149

That's why the "Semantic Pull Request" bot is red.

rolandpakai commented 3 years ago

Hi @julien

i updated the commit message.

Thanks, Roland

julien commented 3 years ago

Thanks @rolandpakai looking good.

Just edited the commit title and message on GitHub's UI to be the same and added some before/after screenshots.