search

liferay / liferay-ckeditor

Other
8 stars 49 forks source link

fix: LPS-127014 Add balloontoolbar missing style #162

Closed edalgrin closed 3 years ago

edalgrin commented 3 years ago

This PR add the missing styles for the balloontoolbar

Before

After

julien commented 3 years ago

@edalgrin I edited the pull request description to include screenshots of how it looked before these changes and how it looks with these changes (could you please do the same thing next time?)

The CSS changes look OK to me, would you like our resident CSS expert to have a quick look or do you think it's not necessary?

edalgrin commented 3 years ago

could you please do the same thing next time?

Sure! thanks 😄

would you like our resident CSS expert to have a quick look or do you think it's not necessary?

I would say it's not necessary, not because I think "it can't be wrong" but because it's harder to understand the context and why I'm changing that code than the code itself 😬

julien commented 3 years ago

Since this only affects the balloontoolbar plugin when used with the monoo-lexicon skin: which isn't currently used anywhere there's very little of breaking anything, so I'm merging this. Thanks for your help @edalgrin