search

liferay / liferay-ckeditor

Other
8 stars 49 forks source link

fix: pasted text is duplicated when changing language on Web Content creation #167

Closed IstvanD closed 3 years ago

IstvanD commented 3 years ago

Hello,

LPS-131699,

These changes will solve the issue on 7.3.x. On master the issue is not reproducible, because on that branch, Web Content uses ckeditor4-react instead of liferay-ckeditor.

Please review the changes, thanks

wincent commented 3 years ago

So this change is totally opaque. I think you probably meant to create a patch file as described here? Here's an example PR that shows the kind of "shape" we would expect to see for a fix. Note that CI is failing because your submodule is pointing at a not-actually-public commit:

Submodule 'ckeditor-dev' (https://github.com/ckeditor/ckeditor-dev.git) registered for path 'ckeditor-dev'
Cloning into '/home/runner/work/liferay-ckeditor/liferay-ckeditor/ckeditor-dev'...
fatal: remote error: upload-pack: not our ref 9e844094931acf4bb549ede2dab608d68153cc4c
Fetched in submodule path 'ckeditor-dev', but it did not contain 9e844094931acf4bb549ede2dab608d68153cc4c. Direct fetching of that commit failed.

If you have any doubts about the patch process, can you ping us in #t-frontend-infra on Slack? — it will probably be quicker to walk you through it there than in a PR.