liferay / liferay-ckeditor

Other
8 stars 49 forks source link

Updating the ckeditor will create unwanted files in the plugins directory #172

Closed julien closed 3 years ago

julien commented 3 years ago

Back in e2e4c50, we added a new function to download plugins (called downloadPlugin) that aren't included in the ckeditor-dev submodule.

Up to now we only use it to download the scayt and wsc plugins.

The problem is that after updating the ckeditor version with the update command, new files (these updated plugins) will show in git status but our own files (skins that we create for plugins), will also be shown as deleted :scream:

This is because we're removing the plugins/$NAME directory here and also extracting the downloaded plugin in the plugins directory.

Since these plugins are never patched, we don't need to use this downloadPlugin function in our setup our update commands, but we do need to include them in our build.