search

liferay / liferay-ckeditor

Other
8 stars 49 forks source link

fix: update @clayui/css to latest and add more icons #175

Closed julien closed 3 years ago

julien commented 3 years ago

In order to make sure have the latest icons avaible in @clayui/css because we're going to need them for LPS-132048

Additionally as part of LPS-127012, we're adding more icons to our moono-lexicon skin that will be used in the Balloon Editor

julien commented 3 years ago

Hey @julien could you please check my comments with @drakonux ? Thx! smile

Of course, will do. Your comments make sense though, but I didn't find those rtl versions (maybe that I didn't check properly).

drakonux commented 3 years ago

The check, folder, and color-picker icons don't need to be mirrored because are common symbols where the direction is not relevant (e.g. message icon has to be mirrored because the direction is relevant in an RTL scenario). The low vision icon doesn't need to be mirrored because slashes are not mirrored either.

julien commented 3 years ago

Thanks for the quick confirmation @drakonux

julien commented 3 years ago

In any case and just to keep the conversation going: using CSS transform, would probably be enough to get a missing rtl icon. Doesn't sound like a crazy idea.

drakonux commented 3 years ago

Yeah, in fact probably I created some RTL icons that I shouldn't... so little by little, we will adjust this because I'm a bit inexperienced in this topic and I think none of us.

markocikos commented 3 years ago

LGTM!