search

liferay / liferay-ckeditor

Other
8 stars 49 forks source link

chore: update ckeditor-dev to 4.16.1 #179

Closed jonmak08 closed 3 years ago

jonmak08 commented 3 years ago

Hey @liferay,

Attached is an update for to upgrade CKEditor to 4.16.1.

Please let me know if you have any questions. Thanks!

julien commented 3 years ago

Hi @jonmak08, The code changes look OK to me. We usually send a pull request updating ckeditor to the new version and an automatic commit is added when running the build(+applying patches) and releasing a new version, but I don't think it's much of a problem to do it this way either. I've also tested this in DXP and haven't seen any problem so you've got my approval.

jonmak08 commented 3 years ago

Thanks guys! I was wondering what the workflow was, but I figured I would send the base changes over first then send all the merge commits and build changes next since those seem to occur after the merge commit based on the Git history I see.

Thanks for reviewing guys!