fix: CodeMirror plugin cannot handle multiple instances

liferay / liferay-ckeditor

Other

8 stars 49 forks source link

fix: CodeMirror plugin cannot handle multiple instances #185

Closed NemethNorbert closed 3 years ago

NemethNorbert commented 3 years ago

Hey,

LPS-136195

I created codeMirrorInstance for codeMirrorEditor to make sure it can handle multiple instances of the ckeditor with the source plugin. Please review my changes

Fixes #184

diegonvs commented 3 years ago

Hey @NemethNorbert, could you add a "Fixes #184" in the PR description? It will help to close the issue automatically once merged :)

NemethNorbert commented 3 years ago

Hey @diegonvs ,

I hope I managed to accomplish the PR description update as you wanted :) Could you please move this PR forward if you don't see any issue with it? Thank you