Place frontend-editor-ckeditor-sample-web on a page.
See movies of the bug the linked ticket.
Comment out this block of code, overriding of CKEDITOR.ui.panel.prototype.showBlock. This block is inadequate to fix this issue, and prevents the solution in this PR to work correctly.
The root cause of the issue is that id of buttons is changing with each render. On the other side, blocks are tied to id of the button that created them. addBlock sets this._.blocks[ name ]only on creation. With the seconds render, link through id is lost.
Notes:
This should not affect classic ckeditor, as buttons are rendered only once.
richcombo is an example where id of trigger is set only once, in constructor, and not on each render.
Fixes: https://issues.liferay.com/browse/LPS-136119
To reproduce:
frontend-editor-ckeditor-sample-webon a page.CKEDITOR.ui.panel.prototype.showBlock. This block is inadequate to fix this issue, and prevents the solution in this PR to work correctly.The root cause of the issue is that
idof buttons is changing with each render. On the other side, blocks are tied toidof the button that created them.addBlocksetsthis._.blocks[ name ]only on creation. With the seconds render, link throughidis lost.Notes:
richcombois an example whereidof trigger is set only once, in constructor, and not on each render.After PR: