fix: adjusts richcombo styles when rendering rtl languages

diegonvs commented 2 years ago

Before:

https://user-images.githubusercontent.com/7663513/144684814-cf3a05a4-96a2-48db-92df-d2849ea2b0e0.mov

After:

https://user-images.githubusercontent.com/7663513/144684851-eba590bc-ef28-48bd-b751-61afd134d36a.mov

What need to be done:

~~When ./ck.sh build and then updating build things on DXP, it is not update. Does somebody have any clue?~~

Literally what needs to be done is

Change .cke_rtl .cke_combo_off a.cke_combo_button:hover

Change padding to 6px 18px;

Remove margin-left: -1px;

Remove margin-right: 0;

Change the margin to: 0 0 0 4px;

When I do this on browser level, it seems ok. However, using this build artifact it is not updated

Fixed!

diegonvs commented 2 years ago

Push force with a new version, see the recording:

https://user-images.githubusercontent.com/7663513/144877287-a06169f0-97a9-405f-b796-ba4c785789b7.mov

diegonvs commented 2 years ago

Now, it's ready for review!

bryceosterhaus commented 2 years ago

LGTM! Nice job @diegonvs

liferay / liferay-ckeditor

fix: adjusts richcombo styles when rendering rtl languages #193