It updates ckeditor's base version to 4.18.0 to solve errors like:
ckeditor.js?browserId=chrome&languageId=en_US&b=7403&t=1647293976851:1216 Uncaught ReferenceError: CKEDITOR is not defined
{{ at MutationObserver.<anonymous>}}
when navigating from a page that an editor was mounted to another one.
I needed to remove this LOC where it was responsible for downloading wsc in order for the build script to run properly.
About wsc depending usages:
Inside liferay-ckeditor:
I noticed we're setting some styles/skin on moono-lexicon related to wsc plugin. So, I removed this CSS file
Inside liferay-portal:
When grepping around DXP, I identified only an import thing related to testing at this file where tests are trying to assert if wsc plugin was downloaded or not. After talking with @john-co, We decided to just remove it because it was unused.
What it does
It updates ckeditor's base version to 4.18.0 to solve errors like:
when navigating from a page that an editor was mounted to another one.
There is a ticket for it: https://issues.liferay.com/browse/LPS-149452
Things to keep an eye(or maybe both eyes)
When I ran
./ck.sh build, I got some errors about wsc not being available to download, and when I checked the ckeditor changelog, I discovered they had removed/deprecated wsc.I needed to remove this LOC where it was responsible for downloading wsc in order for the build script to run properly.
About wsc depending usages:
I noticed we're setting some styles/skin on moono-lexicon related to wsc plugin. So, I removed this CSS file
When grepping around DXP, I identified only an import thing related to testing at this file where tests are trying to assert if wsc plugin was downloaded or not. After talking with @john-co, We decided to just remove it because it was unused.
There is a ticket for it as a sub task: https://issues.liferay.com/browse/LPS-150162