fix: LPS-166086 Make dialog close button accessible with keyboard - Githubissues

liferay / liferay-ckeditor

Other

8 stars 49 forks source link

fix: LPS-166086 Make dialog close button accessible with keyboard #200

Closed markocikos closed 2 years ago

markocikos commented 2 years ago

References

LPS-166086 CKEditor modals cannot be closed by keyboard focusing "X" button

What is the goal of this PR?

In the PR, we are:

Adding close button to the list of focusable items in dialog.
Fixing outline styles in DXP, by adding close CSS class.
Fixing close event JS error when close is done over keyboard.

What does it look like?

I wanted to add a gif here, but my recording software (peek on ubuntu) refused to record focus changes. Here is a screenshot:

screen

Steps to reproduce

See steps to reproduce in JIRA ticket.