search

liferay / liferay-ckeditor

Other
8 stars 49 forks source link

LPD-33910 Add sanitization for codeMirror editor #212

Closed fortunatomaldonado closed 1 month ago

fortunatomaldonado commented 1 month ago

https://liferay.atlassian.net/browse/LPD-33910 https://liferay.atlassian.net/browse/LPP-55225

CodeMirror editor was not being sanitized and so adding sensitization prevents any unexpected behavior. I tried several examples and was not able to get any unexpected behavior.

Please let me know if there are any questions or comments about this. Thank you!

fortunatomaldonado commented 1 month ago

Thank you @bryceosterhaus! @markocikos, can we get this pull and https://github.com/liferay/liferay-ckeditor/pull/213 merged? Also if we can get the version upgraded, I wasn't able to do it before.

Thank you!

markocikos commented 1 month ago

@fortunatomaldonado you don't need to generate artifacts on each PR, that's what caused the conflicts after I merged https://github.com/liferay/liferay-ckeditor/pull/213. We only need to generate them once before release. Historically there was rarely more then one PR per release, so it was custom to add them immediately in PR. But it's not necessary, especially if you expect multiple fixes soon.

fortunatomaldonado commented 1 month ago

@markocikos, oh I see. I'll remove the artifacts here and resend. Thank you!