LPD-34946 Check if values are empty and delete styles when not used - Githubissues

liferay / liferay-ckeditor

Other

8 stars 49 forks source link

LPD-34946 Check if values are empty and delete styles when not used #213

Closed fortunatomaldonado closed 2 months ago

fortunatomaldonado commented 2 months ago

https://liferay.atlassian.net/browse/LPP-55392 https://liferay.atlassian.net/browse/LPD-34946

Hello,

Using the Image Properties, the image gets style="margin: 0px;” added. This is no longer removable even if the entries are empty.

Before Screencast from 08-27-2024 01:36:12 PM.webm

I made changed so that the styles are removed and no longer added if the entries are blank.

After

Screencast from 08-27-2024 01:27:16 PM.webm

Let me know if there are any questions or comments about this. Thank you!

fortunatomaldonado commented 2 months ago

Thank you @bryceosterhaus! @markocikos, can we get this pull and https://github.com/liferay/liferay-ckeditor/pull/212 merged? Also if we can get the version upgraded, I wasn't able to do it before.

Thank you!