search

liferay / liferay-frontend-projects

A monorepo containing assorted Frontend Infrastructure Team projects
Other
69 stars 69 forks source link

fix: LPS-167272 Multiple events are being read in reverse order #1052

Closed markocikos closed 1 year ago

markocikos commented 1 year ago

References

What is the goal of this PR?

This change fixes part of the ticket, an incorrect order of tabs in a day.

In PR, we are changing the order of nodes in DOM. With this change, nodes are accessed through keyboard navigation in chronological order. Order in DOM is irrelevant for display, as the positioning is absolute.

What does it look like?

Before PR

https://user-images.githubusercontent.com/5435511/207394804-926dd0a5-fbf3-46ee-b68f-1b0aebb644d8.mp4

After PR

https://user-images.githubusercontent.com/5435511/207394780-75b79717-c1a7-4830-a2c7-78e1940dac8f.mp4

bryceosterhaus commented 1 year ago

LGTM! Only change needed is the title of the PR to follow the conventional commits pattern