search

liferay / liferay-frontend-projects

A monorepo containing assorted Frontend Infrastructure Team projects
Other
69 stars 69 forks source link

npm-scripts breaks vite file #1078

Open allen-ziegenfus opened 1 year ago

allen-ziegenfus commented 1 year ago

I am having a problem with the lint fixing part of npm scripts. We are working on a project with vite and it changes this vite-env.d.ts in such a way that it no longer builds:

/// <reference types="vite/client" />

it changes that to:

// / <reference types="vite/client" />

bryceosterhaus commented 1 year ago

@allen-ziegenfus is there an example in portal we can test against? Or do we need to just add that fie ourselves to test?

allen-ziegenfus commented 1 year ago

@bryceosterhaus we don't have it merged yet but here is the current branch with the file:

https://github.com/allen-ziegenfus/liferay-portal/blob/vite-update-2023-02-16/workspaces/liferay-marketplace-workspace/client-extensions/liferay-marketplace-custom-element/src/vite-env.d.ts

bryceosterhaus commented 1 year ago

Thanks! I created an LPS to track this so that it can be added to a sprint of ours, https://issues.liferay.com/browse/LPS-176124