search

liferay / liferay-frontend-projects

A monorepo containing assorted Frontend Infrastructure Team projects
Other
69 stars 69 forks source link

bs3-bs4-compat: Add Lexicon 1.x mixins that were removed in Clay 2.x / 3.x #1091

Closed pat270 closed 1 year ago

pat270 commented 1 year ago

Issue type (mark with x)

Version (mark with x)

Description

Some mixins are missing when upgrading 7.1 themes to 7.4. The bs3-bs4-compat layer should also include Lexicon 1.x mixins that were removed.

Desired behavior:

Current behavior:

Repro instructions (if applicable):

Other information (environment, versions etc):

izaera commented 1 year ago

Can you please specify how to upgrade from 7.1 to 7.4 and provide some steps we can follow to reproduce it? IINM you need to use several Themes Toolkit versions? :thinking: I mean, I think you cannot do it with a single step, IIRC...

pat270 commented 1 year ago

@izaera I'm going off this thread. I guess it's not really a 7.1 theme, but one that is currently going through the process of being upgraded. They're running into some issues that could be fixed in the compatibility layer.

Edit: Their theme is relying on some Lexicon 1.x mixins and variables which no longer exist in Clay 2/3.

izaera commented 1 year ago

Mmm, I see...

So, we have two bs3-bs4-compat projects in this repo:

  1. https://github.com/liferay/liferay-frontend-projects/tree/master/projects/js-themes-toolkit/packages/bs3-bs4-compat
  2. https://github.com/liferay/liferay-frontend-projects/tree/master/maintenance/projects/js-themes-toolkit-v10-x/packages/bs3-bs4-compat

One is for the current Themes Toolkit version (v11), the other one is for the v10 series.

pat270 commented 1 year ago

@izaera probably all of them. I'll send you a pr and you can take a look at it.

Edit: It's copying and pasting some mixins from Lexicon 1.x into bs3-bs4-compat.

izaera commented 1 year ago

A PR would be great :+1: Thx