liferay / liferay-frontend-projects

A monorepo containing assorted Frontend Infrastructure Team projects
Other
69 stars 69 forks source link

Given an empty React fragment, our empty-line-between-sibling-elements rule is not properly enforced #1098

Open kresimir-coko opened 1 year ago

kresimir-coko commented 1 year ago

Issue type (mark with x)

Description

Given an empty React fragment <></>, our empty-line-between-sibling-elements rule is not checked. Code example:

<>
    <ClayDropDown.Caption className="pb-0">
        <ClayAutocomplete>
            ...
        </ClayAutocomplete>
        // NOTE: It works for these 2 sibling elements
        {selectedItems.length ? (
            <div className="mt-2 selected-elements-wrapper">
                ...
            </div>
        ) : null}
    </ClayDropDown.Caption>
    <Divider /> // NOTE: This is where it should get triggered, too, but it's not
</>
izaera commented 1 year ago

I think the problem is not just with the empty fragment. I've run SF in frontend-data-set-web too, with changes to the utils/modules.js file and it ignored me :shrug: .

bryceosterhaus commented 1 year ago

internal ticket, https://issues.liferay.com/browse/LPS-177900