Closed georgel-pop-lr closed 1 year ago
Adding the gulp script is a little odd at first glance... But I guess not necessarily wrong. shrug Hi,
I agree but is very useful, I always added it myself by hand, but I guess if people see it there they would use it.
Regards.
@georgel-pop-lr you can achieve the same functionality by running npx gulp
in the project folder (without having to install the package globally)
Also, I think that ./node_modules/bin/...
thing may fail in Windows
And in some circumstances, it will also fail if yarn hoists it.
TBH, I would send a follow-up to change that to either remove the script or use:
"scripts": {
"gulp": "npx gulp"
}
Or even better:
"scripts": {
"gulp": "gulp"
}
I think that works too and doesn't fail under yarn or windows scenarios.
And in some circumstances, it will also fail if yarn hoists it.
TBH, I would send a follow-up to change that to either remove the script or use:
"scripts": { "gulp": "npx gulp" }
Or even better:
"scripts": { "gulp": "gulp" }
I think that works too and doesn't fail under yarn or windows scenarios.
Thanks for your suggestion: https://github.com/liferay/liferay-frontend-projects/pull/1112
Adding the gulp script is a little odd at first glance... But I guess not necessarily wrong. 🤷