liferay / liferay-frontend-projects

A monorepo containing assorted Frontend Infrastructure Team projects
Other
69 stars 69 forks source link

chore: add git ignore .idea files #1109

Closed georgel-pop-lr closed 1 year ago

bryceosterhaus commented 1 year ago

Adding the gulp script is a little odd at first glance... But I guess not necessarily wrong. 🤷

georgel-pop-lr commented 1 year ago

Adding the gulp script is a little odd at first glance... But I guess not necessarily wrong. shrug Hi,

I agree but is very useful, I always added it myself by hand, but I guess if people see it there they would use it.

Regards.

izaera commented 1 year ago

@georgel-pop-lr you can achieve the same functionality by running npx gulp in the project folder (without having to install the package globally)

izaera commented 1 year ago

Also, I think that ./node_modules/bin/... thing may fail in Windows

izaera commented 1 year ago

And in some circumstances, it will also fail if yarn hoists it.

TBH, I would send a follow-up to change that to either remove the script or use:

"scripts": {
     "gulp": "npx gulp"
}

Or even better:

"scripts": {
     "gulp": "gulp"
}

I think that works too and doesn't fail under yarn or windows scenarios.

georgel-pop-lr commented 1 year ago

And in some circumstances, it will also fail if yarn hoists it.

TBH, I would send a follow-up to change that to either remove the script or use:

"scripts": {
     "gulp": "npx gulp"
}

Or even better:

"scripts": {
     "gulp": "gulp"
}

I think that works too and doesn't fail under yarn or windows scenarios.

Thanks for your suggestion: https://github.com/liferay/liferay-frontend-projects/pull/1112