liferay / liferay-frontend-projects

A monorepo containing assorted Frontend Infrastructure Team projects
Other
69 stars 69 forks source link

feat(npm-scripts): ignore dependency check for modules that have their own yarn.lock #1130

Closed bryceosterhaus closed 1 year ago

bryceosterhaus commented 1 year ago

Before this change we do a greedy check against ALL package.json files. We had thought that every package.json would need to follow the same dependency rules, but now with the introduction of client extensions, these package.json files will work within their own "workspace" and is isolated from liferay-portal. So now we check if the package.json has a sibling yarn.lock file, and if it does then we don't worry about that project.

bryceosterhaus commented 1 year ago

one of these days I will actually look into the windows npm cache issue for our ci