liferay / liferay-frontend-projects

A monorepo containing assorted Frontend Infrastructure Team projects
Other
69 stars 69 forks source link

feat(npm-scripts): improve strategy for generating types, only generate types for modules that have changes to ts files or if their dependencies have changes #1146

Closed bryceosterhaus closed 1 year ago

bryceosterhaus commented 1 year ago

Here the goal is to only generate types when ts files have been changed. This is particularly helpful when running ant format-source-current-branch

The strategy is to diff against the liferay working branch (master). If there are any typescript files changed then we re-build types for that module and it's dependents.

Here is the new output:

izaera commented 1 year ago

LGTM

izaera commented 1 year ago

One more question (I missed the screenshots before approval). What happens with ant format-source-local-changes? Will it work correctly? :thinking:

bryceosterhaus commented 1 year ago

Hmm. I haven't run that before. I will test and see