Closed markocikos closed 10 months ago
What do you think?
:ok_hand:
Only thing that came to mind after writing the :ok_hand: ...
It's not really an HTMLBuilder
but an HTMLElementBuilder
. I don't think it matters so much because both concepts are equivalent but if we plan to have builders that return strings (as opposed to HTMLElement
s) in the future it can be worth reserving the name HTMLBuilder
for stuff that returns strings and use HTMLElementBuilder
for this. Maybe... 🤷
I'm pretty flexible either way, but if I had to lean one way I would say go with HTMLElementBuilder
since we are explicitly expecting it to return a single HTMLElement
Good point! I'll push the change with rename.
@bryceosterhaus Do we need to manually publish @liferay/js-api
? Any special process to do this? Looking at versions, I guess it would be 0.4.0-pre.0.
Yep we would need to manually publish, I can do so later this afternoon or tomorrow
References
What is the goal of this PR?
In the PR, we are introducing the
HTMLBuilder
naming convention to public API:*Renderer
is not quite right, as this is a property of a "Renderer" in DXP.*Component
would not be right, as the function is not used as a React component. It's used as a plain old function.FDSFilter
, might be confusing, as there are objects with the same name in DXP.htmlBuilder
as an argument of the ClientExtension component.We are only adding API, and not renaming, so that the existing contracts don't break. After we migrate usages in DXP, we can delete old API here.
@bryceosterhaus @izaera What do you think?