gulp build failed with fresh liferay theme projects

lockandfire commented 10 months ago

Issue type (mark with `x`)

[x] :thinking: Question
[x] :bug: Bug report
[ ] :gift: Feature request
[ ] :woman_shrugging: Other

Version (mark with `x`)

[ ] :eight: v8.x
[ ] :nine: v9.x
[x] :keycap_ten: v10.x or higher

Description

We started to come across this problem maybe days ago. The reason might be some changes in the dependencies because our old workspaces with existing package-lock.json work well. We are not certain about this but decide to report as an issue. Thank you so much.

- target: dxp 7.4 - node: v16.13.2 with npm 8.1.2 - yo: 4.3.0 with generator-liferay-theme 10.2.1 - gulp: 4.0.2 - local: mac os 11.6.8

If we generate a fresh new liferay theme project with yo liferay-theme eg. a-test-theme, and let npm to initialize the workspace, we will get the following building errors after doing gulp build:

[10:25:31] Starting 'build'...
[10:25:31] Starting 'build:clean'...
[10:25:31] Finished 'build:clean' after 1.08 ms
[10:25:31] Starting 'build:base'...
[10:25:32] Finished 'build:base' after 1.19 s
[10:25:32] Starting 'build:src'...
[10:25:32] Finished 'build:src' after 6.94 ms
[10:25:32] Starting 'build:web-inf'...
[10:25:32] Finished 'build:web-inf' after 1.8 ms
[10:25:32] Starting 'build:liferay-look-and-feel'...
[10:25:32] Finished 'build:liferay-look-and-feel' after 7.47 ms
[10:25:32] Starting 'build:hook'...
[10:25:32] Finished 'build:hook' after 3.22 ms
[10:25:32] Starting 'build:themelets'...
[10:25:32] Starting 'build:themelet-src'...
[10:25:32] Finished 'build:themelet-src' after 589 μs
[10:25:32] Starting 'build:themelet-css-inject'...
[10:25:32] Starting 'build:themelet-js-inject'...
[10:25:32] gulp-inject Nothing to inject into _custom.scss.
[10:25:32] gulp-inject Nothing to inject into portal_normal.ftl.
[10:25:32] Finished 'build:themelet-css-inject' after 8.63 ms
[10:25:32] Finished 'build:themelet-js-inject' after 8.95 ms
[10:25:32] Finished 'build:themelets' after 11 ms
[10:25:32] Starting 'build:rename-css-dir'...
[10:25:32] Finished 'build:rename-css-dir' after 459 μs
[10:25:32] Starting 'build:compile-css'...
[10:25:33] 'build:compile-css' errored after 331 ms
[10:25:33] Error in plugin "sass"
Message:
    build/_css/clay/functions/_type-conversion-functions.scss
Error: Expected number, variable, function, or calculation.
   ╷
40 │         $_: log('Invalid unit `#{$unit}`.');
   │                 ^
   ╵
  build/_css/clay/functions/_type-conversion-functions.scss 40:11  @import
  build/_css/clay/functions/_global-functions.scss 9:9             @import
  build/_css/clay/base.scss 5:9                                    @import
  build/_css/clay.scss 1:9                                         root stylesheet
Details:
    formatted: Error: Expected number, variable, function, or calculation.
   ╷
40 │         $_: log('Invalid unit `#{$unit}`.');
   │                 ^
   ╵
  build/_css/clay/functions/_type-conversion-functions.scss 40:11  @import
  build/_css/clay/functions/_global-functions.scss 9:9             @import
  build/_css/clay/base.scss 5:9                                    @import
  build/_css/clay.scss 1:9                                         root stylesheet
    line: 40
    column: 11
    file: /Users/minwu-aegif/DaiichiSankyo-Projects/dxpc_jekins_repo/theme-test-wkspc/a-test-theme/build/_css/clay/functions/_type-conversion-functions.scss
    status: 1
    messageFormatted: build/_css/clay/functions/_type-conversion-functions.scss
Error: Expected number, variable, function, or calculation.
   ╷
40 │         $_: log('Invalid unit `#{$unit}`.');
   │                 ^
   ╵
  build/_css/clay/functions/_type-conversion-functions.scss 40:11  @import
  build/_css/clay/functions/_global-functions.scss 9:9             @import
  build/_css/clay/base.scss 5:9                                    @import
  build/_css/clay.scss 1:9                                         root stylesheet
    messageOriginal: Expected number, variable, function, or calculation.
   ╷
40 │         $_: log('Invalid unit `#{$unit}`.');
   │                 ^
   ╵
  build/_css/clay/functions/_type-conversion-functions.scss 40:11  @import
  build/_css/clay/functions/_global-functions.scss 9:9             @import
  build/_css/clay/base.scss 5:9                                    @import
  build/_css/clay.scss 1:9                                         root stylesheet
    relativePath: build/_css/clay/functions/_type-conversion-functions.scss
    domainEmitter: [object Object]
    domainThrown: false

[10:25:33] 'build' errored after 1.55 s

dsanz commented 10 months ago

Hey @lockandfire thanks a lot for reporting. We're working to fix this. A new clay-css version will soon be released.

In the meantime you can force the resolution of sass package to version 1.64.1 Best

lockandfire commented 10 months ago

Hello dsanz, thank you for the solutions and waiting for the fix!

liferay / liferay-frontend-projects