liferay / liferay-frontend-projects

A monorepo containing assorted Frontend Infrastructure Team projects
Other
66 stars 67 forks source link

feat(js-api): add types for Editor Config Contributor client extension #1185

Closed markocikos closed 6 months ago

markocikos commented 6 months ago

References

What is the goal of this PR?

Adding public types for Editor Config Contributor client extension.

Notes:

markocikos commented 6 months ago

@izaera I force pushed changes, please take a look. In addition, do you know what causes the Pull Request Labeler / triage check failure? The error is quite cryptic to me, found unexpected type for label '10.x' (should be array of config options)

izaera commented 6 months ago

do you know what causes the Pull Request Labeler / triage check failure?

Looks like an internal issue in GH actions. I'd rerun it again.

izaera commented 6 months ago

LGTM!

markocikos commented 6 months ago

@izaera Can you release new version of @liferay/js-api? I can try, but I'm not sure if I have permissions, or if there are and hidden quirks of this repo.

izaera commented 6 months ago

let me check :+1:

izaera commented 6 months ago

It's as explained here -> https://github.com/liferay/liferay-frontend-projects/blob/master/projects/js-toolkit/CONTRIBUTING.md

I'll try it now bc it's been long since I don't release a version of this project, but IIRC there's nothing special with this project. Only that we are releasing pre-versions until we decide to make it effective and start to maintain proper versioning of the contracts.

izaera commented 6 months ago

There you go -> https://github.com/liferay/liferay-frontend-projects/releases/tag/js-api%2Fv0.6.0-pre.0

Next time you simply need to run the steps described in CONTRIBUTING.md.

As for the permissions, you should be fine because we set all our npm packages to the same user group (liferay devs), so you should have permissions too.